Glad it helped!
If you combine the two remaining RUNs into one and do similar optimization in the .sh file, you may reduce it even further! ;) Best, Nitin ________________________________ From: jun aoki <[email protected]> Sent: Friday, September 11, 2015 6:53 PM To: Nitin Lamba Cc: Dan Smith; geode Subject: Re: Review Request 35541: GEODE-60 Geode build environment within Docker to enable anybody and on any OS and any environment can build Geode as long as there is Docker This is cool Nitin, I could indeed reduce the image size. will reattach the patch. Thank you for leting me know! Previous REPOSITORY TAG IMAGE ID CREATED VIRTUAL SIZE geode/build-jaoki latest c8ca6d841cbb 24 hours ago 977.3 MB geode/build latest c60ec778317d 24 hours ago 977 MB After chaining REPOSITORY TAG IMAGE ID CREATED VIRTUAL SIZE geode/build-jaoki latest ec41cb387c7b 15 seconds ago 839.3 MB geode/build latest 1e870e6486bf 16 seconds ago 839 MB On Fri, Sep 11, 2015 at 5:30 PM, Nitin Lamba <[email protected]<mailto:[email protected]>> wrote: Hi Jun, You may also want to consider RUN command chaining within Dockerfile (like William did in docker/Dockerfile). It creates relatively smaller images: https://labs.ctl.io/optimizing-docker-images/ My $0.02, Nitin ________________________________________ From: jun aoki <[email protected]<mailto:[email protected]>> on behalf of jun aoki <[email protected]<mailto:[email protected]>> Sent: Friday, September 11, 2015 3:46 PM To: geode; Dan Smith; jun aoki Subject: Re: Review Request 35541: GEODE-60 Geode build environment within Docker to enable anybody and on any OS and any environment can build Geode as long as there is Docker > On Sept. 11, 2015, 6:43 p.m., Dan Smith wrote: > > Looks good! One very minor comment - we might want to put this is a > > directory with a different name than "build" The gradle output directories > > are called build, so for example our .gitignore file will exclude > > everything in there. Maybe dev-tools/docker? Otherwise, ship it! thank you for letting me know, Dan. will change it - jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35541/#review98660 ----------------------------------------------------------- On Sept. 11, 2015, 6:38 p.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35541/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 6:38 p.m.) > > > Review request for geode. > > > Bugs: GEODE-60 > https://issues.apache.org/jira/browse/GEODE-60 > > > Repository: geode > > > Description > ------- > > Added Dockerfile for docker to build a container which lets users to build > Geode. > > > Diffs > ----- > > README.md 8ac89a0 > dev-tools/build/Dockerfile PRE-CREATION > dev-tools/build/start-docker.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/35541/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > jun aoki > > -- -jun
