-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36515/
-----------------------------------------------------------

Review request for geode and Darrel Schneider.


Bugs: GEODE-108
    https://issues.apache.org/jira/browse/GEODE-108


Repository: geode


Description
-------

GEODE-108: Fix up HAInterestPart*DUnitTests

Reformat, fix timeouts, reduce interval for checking asynchronous
criteria. Move tearDown2 up by setUp. Null out static fields during
closeCache so other dunit JVMs don't leak Cache/DS instances. Remove
sleep call. Add @SuppressWarning and @Override annotations. Use
addExpectedExceptions to fix suspect string failures (including the
one that Jenkins hit). Fix typos.

Add JUnit 4 TestCase for testing these tests together in isolation.


Diffs
-----

  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestBaseTest.java
 cce74ff 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestDistributedTestCase.java
 PRE-CREATION 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestPart1DUnitTest.java
 f3f3608 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestPart2DUnitTest.java
 8bad0b2 

Diff: https://reviews.apache.org/r/36515/diff/


Testing
-------

HAInterestPart1DUnitTest, HAInterestPart2DUnitTest, 
HAInterestDistributedTestCase


Thanks,

Kirk Lund

Reply via email to