----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36515/#review91979 -----------------------------------------------------------
Ship it! I didn't see any problems. But with all the changes I was not able to review them all. I think when we do a reformatting of existing code we should do it in a seperate commit since it can cause lots of diffs. - Darrel Schneider On July 15, 2015, 11:18 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36515/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 11:18 a.m.) > > > Review request for geode and Darrel Schneider. > > > Bugs: GEODE-108 > https://issues.apache.org/jira/browse/GEODE-108 > > > Repository: geode > > > Description > ------- > > GEODE-108: Fix up HAInterestPart*DUnitTests > > Reformat, fix timeouts, reduce interval for checking asynchronous > criteria. Move tearDown2 up by setUp. Null out static fields during > closeCache so other dunit JVMs don't leak Cache/DS instances. Remove > sleep call. Add @SuppressWarning and @Override annotations. Use > addExpectedExceptions to fix suspect string failures (including the > one that Jenkins hit). Fix typos. > > Add JUnit 4 TestCase for testing these tests together in isolation. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestBaseTest.java > cce74ff > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestDistributedTestCase.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestPart1DUnitTest.java > f3f3608 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestPart2DUnitTest.java > 8bad0b2 > > Diff: https://reviews.apache.org/r/36515/diff/ > > > Testing > ------- > > HAInterestPart1DUnitTest, HAInterestPart2DUnitTest, > HAInterestDistributedTestCase > > > Thanks, > > Kirk Lund > >
