----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36662/#review92963 -----------------------------------------------------------
gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java (line 104) <https://reviews.apache.org/r/36662/#comment147235> I know it's picky, but "Initializing (with an 'l'). gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java (line 143) <https://reviews.apache.org/r/36662/#comment147236> Spelling, initializing gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java (line 195) <https://reviews.apache.org/r/36662/#comment147237> Spelling ... Initializing gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java (line 306) <https://reviews.apache.org/r/36662/#comment147239> Failed "to" (vs. ot). gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java (line 341) <https://reviews.apache.org/r/36662/#comment147240> Maybe this message could be better (I know it is not customer facing) ... also Grabbed (two bs). gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java (line 350) <https://reviews.apache.org/r/36662/#comment147242> released vs. release - Lynn Hughes-Godfrey On July 24, 2015, 6:28 p.m., Ashvin A wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36662/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 6:28 p.m.) > > > Review request for geode, Lynn Hughes-Godfrey and Dan Smith. > > > Repository: geode > > > Description > ------- > > Spec: https://cwiki.apache.org/confluence/display/GEODE/Automated+Rebalancing > > * Create a sub-project for auto-rebalancer > * Commit quartz based scheduler to parse and interpret cron strings > * Add a new DistributedLockService and Object for AutoBalancer > * Create stat for auto-rebalance-attempts in ResourceStats > > > What package name should be used for new classes. I have added a new class > AutoBalancer? If we will be updating package name to org.apache in future, > then I can leave it as com.gemstone for now. All packages will be updated at > the same time. Alternatively, all new code could start using a new package. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/ResourceManagerStats.java > 79a3c96 > gemfire-rebalancer/build.gradle PRE-CREATION > > gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java > PRE-CREATION > > gemfire-rebalancer/src/test/java/com/gemstone/gemfire/cache/util/AutoBalancerJUnitTest.java > PRE-CREATION > settings.gradle 7f6ed61 > > Diff: https://reviews.apache.org/r/36662/diff/ > > > Testing > ------- > > > Thanks, > > Ashvin A > >
