----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36662/#review93362 -----------------------------------------------------------
Ship it! It might be better to check each individual region for balance, rather than the whole system, to avoid needlessly rebalancing regions that are already balanced. But this looks good for what it is doing now. It also might be better to not release the auto rebalance lock if a member acquires it. That would prevent races where two different members would both do the auto rebalance check - so it would avoid some extra messaging to gather metadata. It would also mean that only a single member will do auto rebalancing until that member dies. But maybe that might make it easier to read the logs. - Dan Smith On July 27, 2015, 7:16 p.m., Ashvin A wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36662/ > ----------------------------------------------------------- > > (Updated July 27, 2015, 7:16 p.m.) > > > Review request for geode, Lynn Hughes-Godfrey and Dan Smith. > > > Repository: geode > > > Description > ------- > > Spec: https://cwiki.apache.org/confluence/display/GEODE/Automated+Rebalancing > > * Create a sub-project for auto-rebalancer > * Commit quartz based scheduler to parse and interpret cron strings > * Add a new DistributedLockService and Object for AutoBalancer > * Create stat for auto-rebalance-attempts in ResourceStats > > > What package name should be used for new classes. I have added a new class > AutoBalancer? If we will be updating package name to org.apache in future, > then I can leave it as com.gemstone for now. All packages will be updated at > the same time. Alternatively, all new code could start using a new package. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/ResourceManagerStats.java > 79a3c96 > gemfire-rebalancer/build.gradle PRE-CREATION > > gemfire-rebalancer/src/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java > PRE-CREATION > > gemfire-rebalancer/src/test/java/com/gemstone/gemfire/cache/util/AutoBalancerJUnitTest.java > PRE-CREATION > settings.gradle 7f6ed61 > > Diff: https://reviews.apache.org/r/36662/diff/ > > > Testing > ------- > > > Thanks, > > Ashvin A > >
