> On Aug. 27, 2015, 12:35 a.m., anilkumar gingade wrote: > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListener.java, > > line 49 > > <https://reviews.apache.org/r/37822/diff/1/?file=1055468#file1055468line49> > > > > Why its called SingleIndexRepository...Will there be a AsyncListner for > > each Lucene index created on the region?
Good point, I suppose a single AsyncEventListener could handle multiple LuceneIndex objects. I was going to call it LuceneRepository but I think Gester was already creating a class with that name. Will discuss. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37822/#review96618 ----------------------------------------------------------- On Aug. 27, 2015, 12:13 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37822/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 12:13 a.m.) > > > Review request for geode, Ashvin A and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Adding an implementation of the listener and a unit test. I also added > several other interfaces for collaborators with this AsyncEventListener. > > SingleIndexRepository - Interface for a single lucene index (in other > words, a single index on a single bucket for a PR). This currently has > methods for writing to the index. > > RepositoryManager - interface for obtaining SingleIndexRepository > objects based on a user region and a key. > > ObjectToDocumentMapper - interface for translating a gemfire object > into an indexable document. > > > Diffs > ----- > > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListener.java > PRE-CREATION > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/ObjectToDocumentMapper.java > PRE-CREATION > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/RepositoryManager.java > PRE-CREATION > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepository.java > PRE-CREATION > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImpl.java > PRE-CREATION > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListenerJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37822/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
