----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37822/#review96766 -----------------------------------------------------------
gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/ObjectToDocumentMapper.java (line 16) <https://reviews.apache.org/r/37822/#comment152416> Given the name of the interface and javaDoc for this method, I thought the return type will be a Lucene Document object? gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/ObjectToDocumentMapper.java (line 22) <https://reviews.apache.org/r/37822/#comment152418> I may not have understood this correctly. Is there one lucene doc per KV? If so then there will be a 1-to-1 mapping between Key and docid. DocId is an integer. Geode will need to add and delete docId from the index. What is the role of Term? gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/RepositoryManager.java (line 7) <https://reviews.apache.org/r/37822/#comment152412> Can a user can define multiple indexes on a region? If so getRepository will need more inputs to return a SingleIndexRepository? gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImpl.java (line 22) <https://reviews.apache.org/r/37822/#comment152427> This is so confusing. The latest IndexWriter on Lucene trunk has the following method: public void addDocument(IndexDocument doc) and origin/lucene_solr_5_3 branch's IndexWriter has this method public void addDocument(Iterable<? extends IndexableField> doc) Is the API going to change? gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImpl.java (line 32) <https://reviews.apache.org/r/37822/#comment152421> javadoc for writer.deleteDocument = Deletes the document(s) containing any of the terms. The intent is to remove one document related to key and not to remove all documents containing the term. - Ashvin A On Aug. 27, 2015, 12:13 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37822/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 12:13 a.m.) > > > Review request for geode, Ashvin A and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Adding an implementation of the listener and a unit test. I also added > several other interfaces for collaborators with this AsyncEventListener. > > SingleIndexRepository - Interface for a single lucene index (in other > words, a single index on a single bucket for a PR). This currently has > methods for writing to the index. > > RepositoryManager - interface for obtaining SingleIndexRepository > objects based on a user region and a key. > > ObjectToDocumentMapper - interface for translating a gemfire object > into an indexable document. > > > Diffs > ----- > > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListener.java > PRE-CREATION > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/ObjectToDocumentMapper.java > PRE-CREATION > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/RepositoryManager.java > PRE-CREATION > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepository.java > PRE-CREATION > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImpl.java > PRE-CREATION > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListenerJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37822/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
