----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38060/#review97495 -----------------------------------------------------------
Ship it! Hi Nitin, Looks like good progress! I had a few comments/questions: 1. Is there are reason why you added the pulseCompile, pulseTestCompile configurations rather than just use the standard compile and testCompile ones? 2. I think it would be better to just rename and categorize the the tests to follow the conventions, rather than add different test and integrationTest targets. Maybe we can add another JIRA for that? gemfire-assembly/build.gradle (line 188) <https://reviews.apache.org/r/38060/#comment153387> I don't think this is necessary to include the pulse jars in the lib directory - at least when I tried dropping a just the pulse war into the tools/Pulse directory with the old gemfire pulse it worked fine. I'm not sure what the classpath implications of putting them one place vs. the other are though. - Dan Smith On Sept. 2, 2015, 4:32 p.m., Nitin Lamba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38060/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 4:32 p.m.) > > > Review request for geode, Jens Deppe, Mark Bretl, and Dan Smith. > > > Repository: geode > > > Description > ------- > > Create new gradle script for PULSE to build archives (jar, war files) using > the dependencies from existing ant build.xml file. > > These chances will be tracked on GEODE-12 branch until all subtasks are > completed. > > > Diffs > ----- > > build.gradle 3bad39c > gemfire-assembly/build.gradle 0e51563 > gemfire-assembly/src/test/java/AgentUtilJUnitTest.java 0f7563b > pulse/build.gradle PRE-CREATION > settings.gradle 7f6ed61 > > Diff: https://reviews.apache.org/r/38060/diff/ > > > Testing > ------- > > - pulse.war file gets generated correctly and placed in tools/Pulse folder > - Starting locator starts pulse within the embedded jetty instance > - Unit and integration tests are blocked. GEODE-304 is tracking the issue > separately > > > Thanks, > > Nitin Lamba > >
