> On Sept. 2, 2015, 6:59 p.m., Mark Bretl wrote: > >
Echoing what Dan said, great job Nitin! Only a few minor points to follow up on. Thanks for 'porting' the build script from Ant to Gradle! - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38060/#review97513 ----------------------------------------------------------- On Sept. 2, 2015, 6:42 p.m., Nitin Lamba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38060/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 6:42 p.m.) > > > Review request for geode, Jens Deppe, Mark Bretl, and Dan Smith. > > > Repository: geode > > > Description > ------- > > Create new gradle script for PULSE to build archives (jar, war files) using > the dependencies from existing ant build.xml file. > > These chances will be tracked on GEODE-12 branch until all subtasks are > completed. > > > Diffs > ----- > > build.gradle 3bad39c > gemfire-assembly/build.gradle 0e51563 > gemfire-assembly/src/test/java/AgentUtilJUnitTest.java 0f7563b > pulse/build.gradle PRE-CREATION > settings.gradle 7f6ed61 > > Diff: https://reviews.apache.org/r/38060/diff/ > > > Testing > ------- > > - pulse.war file gets generated correctly and placed in tools/Pulse folder > - Starting locator starts pulse within the embedded jetty instance > - Unit and integration tests are blocked. GEODE-304 is tracking the issue > separately > > > Thanks, > > Nitin Lamba > >
