----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38384/#review99316 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSPingPonger.java (line 14) <https://reviews.apache.org/r/38384/#comment156223> These methods need to check the size of the buffer before accessing it. I haven't finished reviewing the test, but you have a new diff to put up so I'm pushing this review to you. - Bruce Schuchardt On Sept. 15, 2015, 5:44 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38384/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 5:44 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh > Khamesra, Jianxia Chen, and Lynn Gallinat. > > > Repository: geode > > > Description > ------- > > First attempt at auto reconnect implementation. > New unit test coverage for files is: > GMSPingPonger (up for renaming): 91.1% > GMSQuorumChecker : 77.2% > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Messenger.java > d01dcd8 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSPingPonger.java > PRE-CREATION > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumChecker.java > PRE-CREATION > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java > 7bd3048 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java > c8358d9 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumCheckerJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/38384/diff/ > > > Testing > ------- > > Will run junit/dunit and hydra tests > > > Thanks, > > Jason Huynh > >
