----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38384/ -----------------------------------------------------------
(Updated Sept. 17, 2015, 9:44 p.m.) Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Lynn Gallinat. Changes ------- Change: 1.) Fix jchannel being closed from JGroupsMessenger on emergency close and stop. Now it will check to see if we are in a reconnect mode before closing the channel 2.) ReconnectDUnitTest.testReconnectALocator infinite loops now. This has something to do with reusing an old channel. If we modify the code to always create a new channel, the test passes 3.) Spawn a new thread for reconnecting. The code that was present attempted to change daemon state while a thread was running 4.) Check array size before using array in GMSPingPonger 5.) Added previousView to JoinLeave. This will be set to the last view and used by the QuorumChecker 6.) Added new JGroupsMessenger tests for emergencyClose and stop. 7.) Moved shutdownCause to Services Repository: geode Description ------- First attempt at auto reconnect implementation. New unit test coverage for files is: GMSPingPonger (up for renaming): 91.1% GMSQuorumChecker : 77.2% Diffs (updated) ----- gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 3ed9607 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java 4cacfc6 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/JoinLeave.java 7bf35ec gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Manager.java f2f7dc1 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Messenger.java d01dcd8 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java f64538c gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSPingPonger.java PRE-CREATION gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumChecker.java PRE-CREATION gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 7bd3048 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java c8358d9 gemfire-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java 26e8586 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/GMSQuorumCheckerJUnitTest.java PRE-CREATION gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java 3b1c1dc Diff: https://reviews.apache.org/r/38384/diff/ Testing ------- Will run junit/dunit and hydra tests Thanks, Jason Huynh
