----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39055/ -----------------------------------------------------------
(Updated Oct. 6, 2015, 5:19 p.m.) Review request for geode, anilkumar gingade, Bruce Schuchardt, Darrel Schneider, and Jianxia Chen. Changes ------- Added comments as suggested Calling objectsEqual in multiple locations Repository: geode Description ------- The previous refactor was a bit aggressive and did not account for struct comparison (I assumed struct equals method would work just fine but apparently not...) It did not show in this specific test but was reflected in 5 failing tests overnight. Diffs (updated) ----- gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/functional/StructSetOrResultsSet.java d53c28b Diff: https://reviews.apache.org/r/39055/diff/ Testing ------- The failing tests QueryREUpdateInProgressJUnitTest and PRColocatedEquiJoinDUnitTest Thanks, Jason Huynh
