----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39055/#review101669 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On Oct. 6, 2015, 10:19 a.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39055/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 10:19 a.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Darrel > Schneider, and Jianxia Chen. > > > Repository: geode > > > Description > ------- > > The previous refactor was a bit aggressive and did not account for struct > comparison (I assumed struct equals method would work just fine but > apparently not...) It did not show in this specific test but was reflected > in 5 failing tests overnight. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/functional/StructSetOrResultsSet.java > d53c28b > > Diff: https://reviews.apache.org/r/39055/diff/ > > > Testing > ------- > > The failing tests QueryREUpdateInProgressJUnitTest and > PRColocatedEquiJoinDUnitTest > > > Thanks, > > Jason Huynh > >
