----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39346/#review105093 -----------------------------------------------------------
Ship it! Ship It! - Kirk Lund On Oct. 15, 2015, 5:42 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39346/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2015, 5:42 p.m.) > > > Review request for geode and Kirk Lund. > > > Bugs: GEODE-405 > https://issues.apache.org/jira/browse/GEODE-405 > > > Repository: geode > > > Description > ------- > > Since toProperties does not include ssl-* properties > sameAs needs to also ignore ssl-* properties. > Since the ssl-* are always copied to cluster-ssl-* > and sameAs compares these it will still return false > if the ssl-* properties had different values. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/AbstractConfig.java > 75e4314d67dbeff8fb6b97d712f689263094e7d7 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java > 88a06542383d50d41f6768b8142c9deb6d988392 > > Diff: https://reviews.apache.org/r/39346/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
