----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40927/#review108923 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java (line 845) <https://reviews.apache.org/r/40927/#comment168379> I think this warrants a comment. // when TCP/IP is disabled we can't throttle the serial queue or we run the risk of distributed deadlock when we block the UDP reader thread gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java (line 4123) <https://reviews.apache.org/r/40927/#comment168378> isTcpDisable is not a good name for this variable. It doesn't convey what your changes are doing, which is disabling throttling, and it will confuse people reading this code in the future. Call it throttlingDisabled. - Bruce Schuchardt On Dec. 3, 2015, 7:56 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40927/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 7:56 p.m.) > > > Review request for geode, Bruce Schuchardt and Darrel Schneider. > > > Repository: geode > > > Description > ------- > > Disabled throttling queue for SerialExcutor when tcp is disable. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java > 5d3bdce > > Diff: https://reviews.apache.org/r/40927/diff/ > > > Testing > ------- > > testing > > > Thanks, > > Hitesh Khamesra > >
