----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43059/#review117302 -----------------------------------------------------------
Ship it! Ship It! - Udo Kohlmeyer On Feb. 1, 2016, 8:27 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43059/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 8:27 p.m.) > > > Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > ViewCreator thread sends another message when any member doesn't ack back to > prepared view. And then it waits on future as this can happen for > multiple members. > In this case, If those members are not responsive and other thread > already determined that, > then we don't need to wait for those members. Thus now viewCreator thread > checks > RemoveMember message for those members while waiting for response. > Another minor fix in same area. > And added unit test for that > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > b6f6c12 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 6b09214 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > 5b53290 > > Diff: https://reviews.apache.org/r/43059/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
