> On Feb. 1, 2016, 9:56 p.m., Bruce Schuchardt wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java, > > line 2273 > > <https://reviews.apache.org/r/43059/diff/1/?file=1228606#file1228606line2273> > > > > I think this should just break out of the for-loop and the newRemovals > > (minus newLeaves) should be added back into the mbrs collection when the > > loop completes.
Thanks Bruce. I have added both removal/leave request to mbrs after the while loop. > On Feb. 1, 2016, 9:56 p.m., Bruce Schuchardt wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java, > > line 2282 > > <https://reviews.apache.org/r/43059/diff/1/?file=1228606#file1228606line2282> > > > > Since there is already a while() loop with a timer I think this sleep > > should be pretty short - on the order of the 100ms you're using for the > > other sleep. I will look little bit more to avoid sleep. - Hitesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43059/#review117270 ----------------------------------------------------------- On Feb. 2, 2016, 12:11 a.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43059/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 12:11 a.m.) > > > Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > ViewCreator thread sends another message when any member doesn't ack back to > prepared view. And then it waits on future as this can happen for > multiple members. > In this case, If those members are not responsive and other thread > already determined that, > then we don't need to wait for those members. Thus now viewCreator thread > checks > RemoveMember message for those members while waiting for response. > Another minor fix in same area. > And added unit test for that > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > b6f6c12 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 6b09214 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > 5b53290 > > Diff: https://reviews.apache.org/r/43059/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
