----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43265/#review118112 -----------------------------------------------------------
Looks good, but it's still lame that we have to do this at all. We're losing support for windows without cygwin and moving away from the standard gradle tooling. Did you test this with an without a fresh checkout to excerise the download method? - Dan Smith On Feb. 5, 2016, 10:34 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43265/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 10:34 p.m.) > > > Review request for geode, Anthony Baker and Dan Smith. > > > Repository: geode > > > Description > ------- > > As suugested in GEODE-826 replaced gradlew script from bigtop script. > deleted: gradle/wrapper/gradle-wrapper.jar, gradlew.bat files. Kept name of > the gradlew only. We need to make sure this while upgrading gradle. > > > Diffs > ----- > > build.gradle 059cf31 > gemfire-assembly/build.gradle 2d6cac9 > gradle/wrapper/gradle-wrapper.jar 05ef575 > gradlew 40e878b > gradlew.bat aec9973 > > Diff: https://reviews.apache.org/r/43265/diff/ > > > Testing > ------- > > tested on linux. will check mac/cygwin. > > > Thanks, > > Hitesh Khamesra > >
