> On Feb. 6, 2016, 12:30 a.m., Dan Smith wrote: > > Looks good, but it's still lame that we have to do this at all. We're > > losing support for windows without cygwin and moving away from the standard > > gradle tooling. > > > > Did you test this with an without a fresh checkout to excerise the download > > method?
1. "without frest checkout", this script will download again as it creates another hash for downloaded folder -bash-4.2$ cd ~/.gradle/wrapper/dists/gradle-2.8-bin/ -bash-4.2$ ls 4rsda7i357a5ogdj89yq8dntm 509a5adbab97b8d10485a259213fc9da 2. This script doesn't provide cygwin support as well, thus I need modify that as well. 3. If windows is concern then for geode "src" we can copy "bigtop" script(we may need to keep this script in some other util folder in repo) and let continue gradlew. 4. Or we can write bat script. Any view? - Hitesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43265/#review118112 ----------------------------------------------------------- On Feb. 5, 2016, 10:34 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43265/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 10:34 p.m.) > > > Review request for geode, Anthony Baker and Dan Smith. > > > Repository: geode > > > Description > ------- > > As suugested in GEODE-826 replaced gradlew script from bigtop script. > deleted: gradle/wrapper/gradle-wrapper.jar, gradlew.bat files. Kept name of > the gradlew only. We need to make sure this while upgrading gradle. > > > Diffs > ----- > > build.gradle 059cf31 > gemfire-assembly/build.gradle 2d6cac9 > gradle/wrapper/gradle-wrapper.jar 05ef575 > gradlew 40e878b > gradlew.bat aec9973 > > Diff: https://reviews.apache.org/r/43265/diff/ > > > Testing > ------- > > tested on linux. will check mac/cygwin. > > > Thanks, > > Hitesh Khamesra > >
