> On Feb. 23, 2016, 12:31 a.m., Dan Smith wrote:
> > I don't think this is actually going to do anything. I see the below code
> > in system.disconnect. It looks like it's already going to wait and make
> > sure the system is disconnected and the flag is set before returning. So
> > I'm not sure there is a case where the system could be left in a state that
> > is in the middle of disconnecting. Did you actually see a difference before
> > and after your changes?
> >
> > // While still holding the lock, make sure this instance is
> > // marked as shutting down
> > synchronized (this) {
> > if (this.isDisconnecting) {
> > // It's already started, but don't return
> > // to the caller until it has completed.
> > waitDisconnected();
> > return;
> > } // isDisconnecting
> > this.isDisconnecting = true;
I couldn't get this test fail in my environment. So this change is only
theoretical. But I do see a bug in my fix. Will work on it more.
- Jinmei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43853/#review120222
-----------------------------------------------------------
On Feb. 22, 2016, 10:17 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43853/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 10:17 p.m.)
>
>
> Review request for geode, Jens Deppe, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-930: the test failed because the VM has received a DisconnectFromDS
> command unexpectedly while executing the commands specified in the test. The
> DisconnectFromDS is invoked in the begining of the test to make sure the VMs
> are started as clean as possible. So hopefully by adding the awaitlity call
> after that would fix this intermittent failure.
>
>
> Diffs
> -----
>
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java
> 21e44b262d44c5db082833aa75e35982ecdfe0b4
>
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java
> 65224e806f906f487820b9b81394a22eb62b6bb2
> geode-core/src/test/java/com/gemstone/gemfire/test/dunit/Invoke.java
> 5a4ca1547dfd57cfb2bc32e5f77729c2425598d5
>
> Diff: https://reviews.apache.org/r/43853/diff/
>
>
> Testing
> -------
>
> the failed test since the change only affects that test only
>
>
> Thanks,
>
> Jinmei Liao
>
>