----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43853/#review120227 -----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/test/dunit/Invoke.java (line 170) <https://reviews.apache.org/r/43853/#comment181653> this should be: vm.invoke(()->Awaitility.await().until(conditionEvaluator)); - Jinmei Liao On Feb. 22, 2016, 10:17 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43853/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 10:17 p.m.) > > > Review request for geode, Jens Deppe, Kirk Lund, and Dan Smith. > > > Repository: geode > > > Description > ------- > > GEODE-930: the test failed because the VM has received a DisconnectFromDS > command unexpectedly while executing the commands specified in the test. The > DisconnectFromDS is invoked in the begining of the test to make sure the VMs > are started as clean as possible. So hopefully by adding the awaitlity call > after that would fix this intermittent failure. > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DeployCommandsDUnitTest.java > 21e44b262d44c5db082833aa75e35982ecdfe0b4 > > geode-core/src/test/java/com/gemstone/gemfire/test/dunit/DistributedTestCase.java > 65224e806f906f487820b9b81394a22eb62b6bb2 > geode-core/src/test/java/com/gemstone/gemfire/test/dunit/Invoke.java > 5a4ca1547dfd57cfb2bc32e5f77729c2425598d5 > > Diff: https://reviews.apache.org/r/43853/diff/ > > > Testing > ------- > > the failed test since the change only affects that test only > > > Thanks, > > Jinmei Liao > >
