----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43788/#review120343 -----------------------------------------------------------
Looks good except for one small thing. Run splitBrain.bt gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java (line 1067) <https://reviews.apache.org/r/43788/#comment181777> Both the "if" and the "else" now invoke contactedBy(), so I think you can pull it out & invoke it before checking to see if the requestId is >= 0. - Bruce Schuchardt On Feb. 23, 2016, 5:41 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43788/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2016, 5:41 p.m.) > > > Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > While doing tcp check, now we do request heartbeat from unresponsive member. > This is udp call and we don't wait for response. It is processed by another > thread. Current thread continue with tcp check and if it fails, then it look > for heartbeat. > > Added unit test > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > beb781d > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java > 9562e41 > > Diff: https://reviews.apache.org/r/43788/diff/ > > > Testing > ------- > > testing > > > Thanks, > > Hitesh Khamesra > >
