----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44035/#review120745 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutAllOperationContext.java (line 153) <https://reviews.apache.org/r/44035/#comment182219> Can this class be moved to an internal package. We really don't want customers to see it in the external javadocs and now that you have made it public it will show up. Since it is static it should be easy to move out of PutAllOperationContext into an internal package. geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutAllOperationContext.java (line 227) <https://reviews.apache.org/r/44035/#comment182214> did you need to make EntrySet public for this fix? geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutAllOperationContext.java (line 236) <https://reviews.apache.org/r/44035/#comment182216> did you need to make EntryIterator public for this fix? geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java (line 10176) <https://reviews.apache.org/r/44035/#comment182213> I think this code would be a little cleaner if you added a local private method like this: private boolean isEntryValueNull(Map.Entry mapEntry) { if (mapEntry instanceof ExportableEntry) { return ((ExportableEntry)mapEntry).isValueNull(); } else { return mapEntry.getValue() == null; } } Then you can just call this method in the "if" and don't need to duplicate the throw code. - Darrel Schneider On Feb. 25, 2016, 11:32 a.m., Jianxia Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44035/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 11:32 a.m.) > > > Review request for geode, Bruce Schuchardt, Darrel Schneider, Hitesh > Khamesra, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Avoid calling PutAllOperationContext.UpdateOnlyMap.exportValue when the map > entry is ExportableEntry. Because calling exportValue will result in > unnecessary deserialization in this case. For this case, > LocalRegion.verifyPutAllMap only need check whether the key or value is null. > No deserialization is required for PutAll map verification. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutAllOperationContext.java > b05216b > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > b6d8c49 > > Diff: https://reviews.apache.org/r/44035/diff/ > > > Testing > ------- > > > Thanks, > > Jianxia Chen > >
