-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44035/#review121013
-----------------------------------------------------------




geode-core/src/main/java/com/gemstone/gemfire/cache/operations/internal/UpdateOnlyMap.java
 (line 38)
<https://reviews.apache.org/r/44035/#comment182601>

    Add a javadoc to getInternalMap saying that it should only be called by 
internal code that wants to  bypass the exportValue method.


- Darrel Schneider


On Feb. 26, 2016, 3:27 p.m., Jianxia Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44035/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2016, 3:27 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Darrel Schneider, Hitesh 
> Khamesra, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Avoid calling PutAllOperationContext.UpdateOnlyMap.exportValue when the map 
> entry is ExportableEntry. Because calling exportValue will result in 
> unnecessary deserialization in this case. For this case, 
> LocalRegion.verifyPutAllMap only need check whether the key or value is null. 
> No deserialization is required for PutAll map verification.
> 
> 
> Diffs
> -----
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutAllOperationContext.java
>  b05216b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/operations/internal/UpdateOnlyMap.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/PutAll.java
>  5d2f5ca 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/PutAll70.java
>  7507299 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/PutAll80.java
>  6a2b072 
> 
> Diff: https://reviews.apache.org/r/44035/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jianxia Chen
> 
>

Reply via email to