-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/#review120761
-----------------------------------------------------------




geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java
 (line 57)
<https://reviews.apache.org/r/44020/#comment182249>

    The code a little further down is supposed to provide the ability to 
discover the war file on the classpath. Please try and utilize that capability 
instead of adding build-specifics here.


- Jens Deppe


On Feb. 25, 2016, 5:41 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44020/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 5:41 p.m.)
> 
> 
> Review request for geode, Anthony Baker and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> A number of unit tests were still sitting in the work queue to be moved to 
> open-source including all of the REST API tests.  This change set shows the 
> build changes and AgentUtil changes needed to accomodate the new tests but 
> does not show the new tests.  The tests are being added to the geode-web-api 
> project, and all of the support classes in geode-core's 
> com.gemstone.gemfire.rest.internal.web.controllers package are being moved to 
> that project.
> 
> 
> Diffs
> -----
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java
>  0310658d2182f90bc8e2041cd0f6b0f0b53c6568 
>   geode-web-api/build.gradle 51848c2b750373cfcc1c5ba9f0b24417ac38745d 
>   gradle/dependency-versions.properties 
> 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60 
> 
> Diff: https://reviews.apache.org/r/44020/diff/
> 
> 
> Testing
> -------
> 
> The new tests pass when run from gradle or eclipse
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Reply via email to