> On Feb. 25, 2016, 8:45 p.m., Jens Deppe wrote: > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java, > > line 57 > > <https://reviews.apache.org/r/44020/diff/1/?file=1271099#file1271099line57> > > > > The code a little further down is supposed to provide the ability to > > discover the war file on the classpath. Please try and utilize that > > capability instead of adding build-specifics here. > > Bruce Schuchardt wrote: > If I rely on the code lower down in the method it will not be executed if > the environment happens to have a GEMFIRE_HOME env variable set. I have one > of these set and it causes the tests to fail. Unit tests shouldn't be > affected by environment variables - especially one that a geode developer > might easily have set in their environment.
Do the tests really warrant a full container being stood up? Could they be exercised using the Spring MVC mock test framework? - Jens ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44020/#review120761 ----------------------------------------------------------- On Feb. 25, 2016, 11:45 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44020/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 11:45 p.m.) > > > Review request for geode, Anthony Baker and Dan Smith. > > > Repository: geode > > > Description > ------- > > A number of unit tests were still sitting in the work queue to be moved to > open-source including all of the REST API tests. This change set shows the > build changes and AgentUtil changes needed to accomodate the new tests but > does not show the new tests. The tests are being added to the geode-web-api > project, and all of the support classes in geode-core's > com.gemstone.gemfire.rest.internal.web.controllers package are being moved to > that project. > > > Diffs > ----- > > geode-assembly/build.gradle 2a46147c04061a709bc5ae7b2ff596a6083ec5a6 > gradle/dependency-versions.properties > 611ee7a413d70d9c72b5ca0a5384b4dee7c26c60 > > Diff: https://reviews.apache.org/r/44020/diff/ > > > Testing > ------- > > The new tests pass when run from gradle or eclipse > > > Thanks, > > Bruce Schuchardt > >
