----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44125/#review121045 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java (line 476) <https://reviews.apache.org/r/44125/#comment182630> change getNoOfFragments to getFragmentCount? geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java (line 486) <https://reviews.apache.org/r/44125/#comment182640> // then freeMemory can not be fragmented geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java (line 489) <https://reviews.apache.org/r/44125/#comment182637> add: assert freeMemory > 0 geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java (line 491) <https://reviews.apache.org/r/44125/#comment182634> how about changing to if (getUsedMemory() == 0)? geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java (line 496) <https://reviews.apache.org/r/44125/#comment182639> // so freeMemory must be > 0 geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java (line 498) <https://reviews.apache.org/r/44125/#comment182642> make sure we don't round off the fraction - Darrel Schneider On Feb. 26, 2016, 5:52 p.m., Sai Boorlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44125/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 5:52 p.m.) > > > Review request for geode and Darrel Schneider. > > > Repository: geode > > > Description > ------- > > GEODE-996: OffheapStats - fragmentation percentage calculation has to be > revisited. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java > a716f144d4d248a346ebf10e6826888c482eef09 > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java > bb5cdebfd0b85f7160e00d383058ab5acfb27bc6 > > geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java > 64032cc768d06148c9c8b476aa047874a8e634eb > > Diff: https://reviews.apache.org/r/44125/diff/ > > > Testing > ------- > > > Thanks, > > Sai Boorlagadda > >
