----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44125/#review121451 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java (line 476) <https://reviews.apache.org/r/44125/#comment183156> I think "getFragmentCount" is better than "getFragmentsCount". geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java (line 494) <https://reviews.apache.org/r/44125/#comment183158> I'd get rid of the abbreviations in this comment. In fact I think this block is clear enough that you don't need a comment. geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java (line 496) <https://reviews.apache.org/r/44125/#comment183157> A better assertion is freeMemory >= ObjectChunk.MIN_CHUNK_SIZE - Darrel Schneider On Feb. 29, 2016, 6 p.m., Sai Boorlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44125/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 6 p.m.) > > > Review request for geode and Darrel Schneider. > > > Repository: geode > > > Description > ------- > > GEODE-996: OffheapStats - fragmentation percentage calculation has to be > revisited. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java > a716f144d4d248a346ebf10e6826888c482eef09 > > geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java > bb5cdebfd0b85f7160e00d383058ab5acfb27bc6 > > geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java > 64032cc768d06148c9c8b476aa047874a8e634eb > > geode-core/src/test/java/com/gemstone/gemfire/management/OffHeapManagementDUnitTest.java > acafada0b7040d2c4f74acea24fd952294d13aa1 > > Diff: https://reviews.apache.org/r/44125/diff/ > > > Testing > ------- > > precheckin in progress > > > Thanks, > > Sai Boorlagadda > >
