----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44548/#review122690 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceImpl.java (line 218) <https://reviews.apache.org/r/44548/#comment184793> Why not simply initialize dateFormat with the default value then you won't need this condition? - Jens Deppe On March 9, 2016, 1:47 a.m., Jianxia Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44548/ > ----------------------------------------------------------- > > (Updated March 9, 2016, 1:47 a.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Try a different date format which is ISO-8601. Now the date format is > configurable by calling PdxInstance.setDateFormat. By default, it is > "mm/dd/yyyy". > > > Diffs > ----- > > > geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/DateTimeUtils.java > 3a92df3 > > geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java > 0245fa0 > geode-core/src/main/java/com/gemstone/gemfire/pdx/PdxInstance.java 7f6b831 > geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/EnumInfo.java > 1240ad1 > > geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceEnum.java > 90410ee > > geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceImpl.java > fa7b961 > > geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/WritablePdxInstanceImpl.java > bb159e7 > geode-core/src/test/java/com/gemstone/gemfire/CopyJUnitTest.java 1af9f71 > > Diff: https://reviews.apache.org/r/44548/diff/ > > > Testing > ------- > > > Thanks, > > Jianxia Chen > >
