----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44548/#review122749 -----------------------------------------------------------
It seems wrong to add this method to PdxInstance. I think it would be more usable to be able to configure that json data format using a system property or gemfire property. That way you don't need to do it on every PdxInstance that ends up being created. Also I think in some use cases the user will never get a chance to call your new method on the PdxInstance because we deserialize directly to the domain class when read-serialized is false. - Darrel Schneider On March 8, 2016, 5:47 p.m., Jianxia Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44548/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 5:47 p.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Try a different date format which is ISO-8601. Now the date format is > configurable by calling PdxInstance.setDateFormat. By default, it is > "mm/dd/yyyy". > > > Diffs > ----- > > > geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/DateTimeUtils.java > 3a92df3 > > geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java > 0245fa0 > geode-core/src/main/java/com/gemstone/gemfire/pdx/PdxInstance.java 7f6b831 > geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/EnumInfo.java > 1240ad1 > > geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceEnum.java > 90410ee > > geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceImpl.java > fa7b961 > > geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/WritablePdxInstanceImpl.java > bb159e7 > geode-core/src/test/java/com/gemstone/gemfire/CopyJUnitTest.java 1af9f71 > > Diff: https://reviews.apache.org/r/44548/diff/ > > > Testing > ------- > > > Thanks, > > Jianxia Chen > >
