----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45993/#review128155 -----------------------------------------------------------
I agree that we should not be including test jars in our product lib. Also, was precheckin or Travis CI run on this change? It looks like tests not in Geode source were run to verify this change. - Mark Bretl On April 10, 2016, 2:59 p.m., Udo Kohlmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45993/ > ----------------------------------------------------------- > > (Updated April 10, 2016, 2:59 p.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen. > > > Repository: geode > > > Description > ------- > > GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending > bind address configuration for http-service-bind-address > > > Diffs > ----- > > geode-assembly/build.gradle b7d05e2ce5fe34d3324e2b55212ff7c8ca02d9e0 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/RestAgent.java > a91df05a9931bddd860a79e6b8783fc991ecc2a4 > > geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java > a8921d7d6f2a062a9aa5e27a8376a7e39c8503d5 > > Diff: https://reviews.apache.org/r/45993/diff/ > > > Testing > ------- > > battery tests rest.bt > > > Thanks, > > Udo Kohlmeyer > >
