-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45993/#review128808
-----------------------------------------------------------




geode-core/src/main/java/com/gemstone/gemfire/management/internal/RestAgent.java
 (line 160)
<https://reviews.apache.org/r/45993/#comment192262>

    Do you want to add log info of bindAddress as well? e.g. before it returns.



geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java
 (line 57)
<https://reviews.apache.org/r/45993/#comment192263>

    How about using 
    
    import org.apache.commons.lang.StringUtils;
    ?



geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java
 (line 72)
<https://reviews.apache.org/r/45993/#comment192264>

    Do you need to log the bindAddress?


- Jianxia Chen


On April 13, 2016, 7:39 p.m., Udo Kohlmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45993/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 7:39 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending 
> bind address configuration for http-service-bind-address
> 
> 
> Diffs
> -----
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/RestAgent.java
>  a91df05 
>   
> geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/swagger/config/RestApiPathProvider.java
>  a8921d7 
> 
> Diff: https://reviews.apache.org/r/45993/diff/
> 
> 
> Testing
> -------
> 
> battery tests rest.bt
> 
> 
> Thanks,
> 
> Udo Kohlmeyer
> 
>

Reply via email to