----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46660/ -----------------------------------------------------------
Review request for geode. Repository: geode Description ------- Catch the exception and throw TransactionDataNodeHasDepartedException to the application. There were no existing unit tests for AbstractPeerTxRegionStub, so so one was added for getRegionKeysForIteration, which overrides the method from TxRegionStub interface. Refactored AbstractRegion.getSystem - removed final keyword to allow subclassing for testing. Diffs ----- geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java 10644cb8f661004dcd35351201ee97044baa936a geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/AbstractPeerTXRegionStub.java 77116eb8a8b9a97fd24c58554f54e4d59c61e3e4 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tx/AbstractPeerTXRegionStubTest.java PRE-CREATION Diff: https://reviews.apache.org/r/46660/diff/ Testing ------- precheckin run with no new failures Thanks, Ken Howe
