----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46660/#review130665 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On April 26, 2016, 10:11 a.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46660/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 10:11 a.m.) > > > Review request for geode, Darrel Schneider, Sai Boorlagadda, and Swapnil > Bawaskar. > > > Repository: geode > > > Description > ------- > > Catch the exception and throw TransactionDataNodeHasDepartedException to the > application. > There were no existing unit tests for AbstractPeerTxRegionStub, so so one was > added for getRegionKeysForIteration, which overrides the method from > TxRegionStub interface. > > Refactored AbstractRegion.getSystem - removed final keyword to allow > subclassing for testing. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java > 10644cb > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tx/AbstractPeerTXRegionStub.java > 77116eb > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tx/AbstractPeerTXRegionStubTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46660/diff/ > > > Testing > ------- > > precheckin run with no new failures > > > Thanks, > > Ken Howe > >
