> On May 2, 2016, 5:01 p.m., Bruce Schuchardt wrote: > > I can only see one place where this collection is being accessed outside of > > synchronization: waitForResults() returns it instead of a copy of the > > collection. > > > > Can't we just make a copy of the collection under synchronization in that > > method instead of changing checkIfDone()?
"getUnresponsiveMembers()" method also need to consider as it returns "notRepliedYet" set, which is called from "prepareAndSendView" method. - Hitesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131330 ----------------------------------------------------------- On May 2, 2016, 4:36 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46896/ > ----------------------------------------------------------- > > (Updated May 2, 2016, 4:36 p.m.) > > > Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > added synchronization with copyOnread > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 9f5648b > > Diff: https://reviews.apache.org/r/46896/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
