> On May 2, 2016, 11:06 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java, > > line 1595 > > <https://reviews.apache.org/r/46896/diff/2/?file=1369119#file1369119line1595> > > > > I still don't like this. getUnresponsiveMembers() is used by the view > > creator to get the collection and then it proceeds to modify it multiple > > times. I think that internally the reply processor should continue to use > > the collection directly and that getUnresponsiveMembers() should > > synchronize and return a copy of the collection. That will result in a lot > > fewer objects being created and will keep the view-creator thread from > > modifying the collection that is internal to the reply processor.
>>That will result in a lot fewer objects being created and will keep the >>view-creator thread from modifying the collection that is internal to the >>reply processor. So we think this is another issue, where viewCreator is modifying the "Set" of replyProcessor. That means orignal fix is right way to go. "waitForResponses" function also returns same "set" that's why I made "copyOnRead" there as well. - Hitesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131408 ----------------------------------------------------------- On May 2, 2016, 10:34 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46896/ > ----------------------------------------------------------- > > (Updated May 2, 2016, 10:34 p.m.) > > > Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > added synchronization with copyOnread > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 9f5648b > > Diff: https://reviews.apache.org/r/46896/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
