----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47004/#review131921 -----------------------------------------------------------
It seems like maybe the Flush API ought to be on the index, not the LuceneServiceImpl. And I thought the intention was to add this to the public API, but it looks like right now this is just an internal API? Please add true unit test for these changes. Regarding your integration test, I don't think this is the right way to test this. You're just assuming the entries won't be flushed by the time your waitForFlush call happens, but what's to prevent them from being flushed by that point? Also, the integration tests should run as fast as possible, so an integration test that puts 1K entries seems excessive. geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java (line 243) <https://reviews.apache.org/r/47004/#comment195962> Remove this log message - we don't need an info level log here. geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java (line 81) <https://reviews.apache.org/r/47004/#comment195963> Maybe name this something like entriesFlushedToIndexAfterWaitForFlushCalled? - Dan Smith On May 5, 2016, 6:23 a.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47004/ > ----------------------------------------------------------- > > (Updated May 5, 2016, 6:23 a.m.) > > > Review request for geode and Dan Smith. > > > Bugs: geode-1351 > https://issues.apache.org/jira/browse/geode-1351 > > > Repository: geode > > > Description > ------- > > This is for test purpose. > > An advanced version will be implemented later using function execution. > > > Diffs > ----- > > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java > 58a9b20 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java > c467a18 > > Diff: https://reviews.apache.org/r/47004/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
