-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47004/#review133395
-----------------------------------------------------------
We have some other tests that had work arounds for this issue. Perhaps we can
fix these to use the new flush method? For example, I think
LuceneIndexCreationIntegrationTest we added Awaitility.await().atMost(60,
TimeUnit.SECONDS).until(() -> {
assertEquals(Arrays.asList("field1"), field1Analyzer.analyzedfields);
assertEquals(Arrays.asList("field2"), field2Analyzer.analyzedfields);
});
Or in LuceneIndexRecoveryHAIntegrationTest
private void waitUntilQueueEmpty(final String aeqId) {
// TODO flush queue
AsyncEventQueue queue = cache.getAsyncEventQueue(aeqId);
Awaitility.waitAtMost(1000, TimeUnit.MILLISECONDS).until(() ->
assertEquals(0, queue.size()));
}
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java
(line 103)
<https://reviews.apache.org/r/47004/#comment197790>
Should we throw an exception if we never get to 0?
- Jason Huynh
On May 16, 2016, 5:39 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47004/
> -----------------------------------------------------------
>
> (Updated May 16, 2016, 5:39 a.m.)
>
>
> Review request for geode, anilkumar gingade and Dan Smith.
>
>
> Bugs: geode-1351
> https://issues.apache.org/jira/browse/geode-1351
>
>
> Repository: geode
>
>
> Description
> -------
>
> This is for test purpose.
>
> An advanced version will be implemented later using function execution.
>
>
> Diffs
> -----
>
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListener.java
> 9fdfd43
>
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java
> 0b5f8fa
>
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java
> c467a18
>
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImplJUnitTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47004/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
