----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47675/#review134211 -----------------------------------------------------------
Ship it! Looks good to me. - Ashvin A On May 20, 2016, 10:18 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47675/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 10:18 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, and > xiaojian zhou. > > > Repository: geode > > > Description > ------- > > There were two tests in LuceneIndexRecoveryHAIntegrationTest that used > disk resources. Moved the overflow test too a LuceneQueriesPersistence > suite, where it will be cleaned up by the DiskRule. > > The recovery test was pretty much the same as an existing test in > LuceneIndexCreationPersistent. > > > Diffs > ----- > > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java > 96b4e93eee313ae98fe9af6463b6e9fc3a7b35c3 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java > PRE-CREATION > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java > d32e6d858b1ee0599f257d5866635c38e0f9946c > > Diff: https://reviews.apache.org/r/47675/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
