----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47543/#review135022 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessage.java (line 238) <https://reviews.apache.org/r/47543/#comment200009> One of the things I see is that PartitionMessage and RemoteOperationMessage have a bunch of transaction related code in common. I think this is because they both implement the TransactionMessage interface. I think we should introduce a new abstract class AbstractTransactionMessage that this shared code can live in. It would extend DistributionMessage. Then these two classes could extend it instead of DistributionMessage. It is also possible that other messages that implement the TransactionMessage interface could instead extend this AbstractTransactionMessage. So instead of doing this work as part of this ticket I'd just file a jira ticket saying that these classes have code duplication and should be refactored. - Darrel Schneider On May 25, 2016, 4:58 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47543/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 4:58 p.m.) > > > Review request for geode, Darrel Schneider and Swapnil Bawaskar. > > > Repository: geode > > > Description > ------- > > This also handles when an inflight msg arrived after the transaction is > completed after a failover. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessage.java > 42ce811 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java > 4b2f904 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java > 626efef > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessageTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessageTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47543/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Eric Shu > >
