----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47543/#review135109 -----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java (line 50) <https://reviews.apache.org/r/47543/#comment200131> I think you no longer use count so you should delete it geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java (line 195) <https://reviews.apache.org/r/47543/#comment200135> I would add ".pollInterval(10, TimeUnit.MILLISECONDS).pollDelay(10, TimeUnit.MILLISECONDS)". geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java (line 209) <https://reviews.apache.org/r/47543/#comment200133> Shouldn't you "assertTrue(latch.await(15...))"? Also I'd increase this to 60 seconds. - Darrel Schneider On May 26, 2016, 3:44 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47543/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 3:44 p.m.) > > > Review request for geode, Darrel Schneider and Swapnil Bawaskar. > > > Repository: geode > > > Description > ------- > > This also handles when an inflight msg arrived after the transaction is > completed after a failover. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessage.java > 42ce811 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java > 4b2f904 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java > 626efef > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessageTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessageTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47543/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Eric Shu > >
