> On May 31, 2016, 9:55 p.m., Jens Deppe wrote: > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java, > > line 1955 > > <https://reviews.apache.org/r/48090/diff/1/?file=1402667#file1402667line1955> > > > > Did this creep in accidentally?
I thought I could sneek it in :-). It's intentional. this line does nothing for an off-line command. - Jinmei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48090/#review135689 ----------------------------------------------------------- On May 31, 2016, 8:22 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48090/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 8:22 p.m.) > > > Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-1469: correctly handle the step arguements in http request > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java > 5ddcc514e2a72a1ec584f2d8755b53df0e59f457 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java > f78c6f924f27ce0ca2bae43c3663f97ee9cd4b98 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ConfigCommandsController.java > ebacd3d6b9d5a49d5a5e20b7598674d1ba0ea146 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/http/ClientHttpRequest.java > 447733d28dc7397ec0d968315152583194bb447f > > Diff: https://reviews.apache.org/r/48090/diff/ > > > Testing > ------- > > prechecking running > > > Thanks, > > Jinmei Liao > >
