----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48090/#review135949 -----------------------------------------------------------
Ship it! Ship It! - Kirk Lund On June 1, 2016, 6:38 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48090/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 6:38 p.m.) > > > Review request for geode, Jens Deppe, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-1469: correctly handle the step arguements in http request > > rework. Turns out we need the expand operation of the UriComponents (some of > our uri do have variables in them). Rework by ending and decoding the stepArgs > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/LauncherLifecycleCommands.java > 5ddcc514e2a72a1ec584f2d8755b53df0e59f457 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/multistep/CLIMultiStepHelper.java > 393f09bc7d92b61a24afdb8e3d4602488864f492 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java > f78c6f924f27ce0ca2bae43c3663f97ee9cd4b98 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ConfigCommandsController.java > ebacd3d6b9d5a49d5a5e20b7598674d1ba0ea146 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/support/LoginHandlerInterceptor.java > cefec91f74b499a60b21961dbbe997532a00da1d > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/web/http/ClientHttpRequest.java > 447733d28dc7397ec0d968315152583194bb447f > > Diff: https://reviews.apache.org/r/48090/diff/ > > > Testing > ------- > > prechecking running > > > Thanks, > > Jinmei Liao > >
