> On June 10, 2016, 7:34 p.m., anilkumar gingade wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java, > > line 55 > > <https://reviews.apache.org/r/48432/diff/1/?file=1411418#file1411418line55> > > > > Is it intentional...We are chaging this from 3 to 30 secs? If its > > required we may need to document this and let support know about this...
It hit this whne I was running a bunch of tests. If there is more than a 3 second pause during startup, the member will fail to start up because later on the monitoring and management code tries to use things that should be initialized by that point. I increased the timeout to 30 seconds to make it less likely for pauses on startup to cause the system to fail to start up due to this stat sampler code. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48432/#review137058 ----------------------------------------------------------- On June 9, 2016, 6:41 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48432/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 6:41 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Jason Huynh, > Jinmei Liao, Kirk Lund, and nabarun nag. > > > Repository: geode > > > Description > ------- > > Adding support to measure statistics with suppliers that are sampled > every sample interval. The suppliers are invoked in a separate thread > than the stat sampler so that slow suppliers won't screw up all stats. > > > Diffs > ----- > > geode-core/src/main/java/com/gemstone/gemfire/Statistics.java > d7f45a50af7ce58e0d65bfd6300821b36864cc9b > > geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsImpl.java > 83d40559ba652474630d04758696f2e9042910e7 > geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java > ebb4177c12f6d67ef2cafb76d7a3d765fb1139ea > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatSamplerStats.java > c70247939a50392e62e264bfb783a37c93a969ae > geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsImpl.java > 2344d9315ca8b2b31e9eba35a350eca44a9b8bec > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsTypeImpl.java > 2a29d46dfc260a40b018af5530a4f1e781e72274 > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/CallbackSampler.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/SampleCollector.java > dfb502bb0aa018a11ab26b10a35da2c5be7c10ac > > geode-core/src/test/java/com/gemstone/gemfire/internal/LocalStatisticsImplJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/StatArchiveWriterReaderJUnitTest.java > bb15ff2ce747a37d87c95931d5e07cbce4ca7be6 > > geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerJUnitTest.java > f2946b619c6272539ba00f10a9fb1444cc095231 > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/CallbackSamplerJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/DummyStatistics.java > a1ea030443f096ba8f0bd8d5fb62a8183f20bcfd > > Diff: https://reviews.apache.org/r/48432/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
