> On June 16, 2016, 6:52 p.m., Kirk Lund wrote: > > geode-core/src/main/java/com/gemstone/gemfire/Statistics.java, line 473 > > <https://reviews.apache.org/r/48432/diff/1/?file=1411416#file1411416line473> > > > > This is a public interface. For backwards compatibility, maybe consider > > providing "default" implementations that do nothing.
I'm not sure that's a good thing to do with default implementations. I think a default implementation should provide the required functionality using existing methods on the interface - in this case the default implementation would provide only a broken method, so I don't think it's actually helping someone who did implement this interface - it would just hide the fact that they need to implement more methods. Up until this point, we have freely added methods to interfaces that we don't expect users to implement (think Region, Cache, etc.). Should we change that policy? It seems like this will limit our ability to evolve the API. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48432/#review138051 ----------------------------------------------------------- On June 9, 2016, 6:41 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48432/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 6:41 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Jason Huynh, > Jinmei Liao, Kirk Lund, and nabarun nag. > > > Repository: geode > > > Description > ------- > > Adding support to measure statistics with suppliers that are sampled > every sample interval. The suppliers are invoked in a separate thread > than the stat sampler so that slow suppliers won't screw up all stats. > > > Diffs > ----- > > geode-core/src/main/java/com/gemstone/gemfire/Statistics.java > d7f45a50af7ce58e0d65bfd6300821b36864cc9b > > geode-core/src/main/java/com/gemstone/gemfire/internal/DummyStatisticsImpl.java > 83d40559ba652474630d04758696f2e9042910e7 > geode-core/src/main/java/com/gemstone/gemfire/internal/HostStatSampler.java > ebb4177c12f6d67ef2cafb76d7a3d765fb1139ea > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatSamplerStats.java > c70247939a50392e62e264bfb783a37c93a969ae > geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsImpl.java > 2344d9315ca8b2b31e9eba35a350eca44a9b8bec > > geode-core/src/main/java/com/gemstone/gemfire/internal/StatisticsTypeImpl.java > 2a29d46dfc260a40b018af5530a4f1e781e72274 > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/CallbackSampler.java > PRE-CREATION > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/SampleCollector.java > dfb502bb0aa018a11ab26b10a35da2c5be7c10ac > > geode-core/src/test/java/com/gemstone/gemfire/internal/LocalStatisticsImplJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/StatArchiveWriterReaderJUnitTest.java > bb15ff2ce747a37d87c95931d5e07cbce4ca7be6 > > geode-core/src/test/java/com/gemstone/gemfire/internal/StatSamplerJUnitTest.java > f2946b619c6272539ba00f10a9fb1444cc095231 > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/CallbackSamplerJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/DummyStatistics.java > a1ea030443f096ba8f0bd8d5fb62a8183f20bcfd > > Diff: https://reviews.apache.org/r/48432/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
