Github user vjr commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/199#discussion_r70616349
  
    --- Diff: geode-client-native/src/cppcache/impl/CppCacheLibrary.cpp ---
    @@ -79,7 +84,6 @@ typedef 
ACE_Singleton<CppCacheLibrary,ACE_Recursive_Thread_Mutex> TheLibrary;
     // internals are prepared. fw_helper framework will handle this.
     CppCacheLibrary* CppCacheLibrary::initLib( void )
     {
    -  ACE::init();
    --- End diff --
    
    OK it will be interesting to see how the geode native client handles such 
scenarios of ACE being used elsewhere. Did you see my other comments, 
especially the one about the "uint8 m_suffixFiller[32];" added to guard against 
what ACE bug? Any other changes other than just this declaration in header that 
I'm missing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to