Comment will be remove. Dor -----Original Message----- From: Anthony Baker [mailto:aba...@pivotal.io] Sent: יום ג 26 יולי 2016 18:22 To: dev@geode.incubator.apache.org Subject: Re: [GitHub] incubator-geode pull request #199: GEODE-88: code fixes for c++ client
Based on my reading of [1] and [2] I don’t think the comment is necessary and should be removed. Any other opinions? Anthony [1] http://www.apache.org/legal/src-headers.html [2] http://www.apache.org/dev/apply-license.html#contributor-copyright > On Jul 26, 2016, at 12:38 AM, doribd <g...@git.apache.org> wrote: > > Github user doribd commented on a diff in the pull request: > > > https://github.com/apache/incubator-geode/pull/199#discussion_r7220166 > 0 > > --- Diff: > geode-client-native/src/cppcache/impl/ThinClientRedundancyManager.hpp --- > @@ -56,7 +56,7 @@ namespace gemfire { > void netDown( ); > void acquireRedundancyLock( ) { m_redundantEndpointsLock.acquire_read( > ); } > void releaseRedundancyLock( ) { m_redundantEndpointsLock.release( ); } > - volatile bool allEndPointDiscon() { return m_IsAllEpDisCon;} > + bool allEndPointDiscon() { return m_IsAllEpDisCon;} //Copyright: > Amdocs Software Systems Limited, 2016 > --- End diff -- > > Are we required to remove this line? > > > --- > If your project is set up for it, you can reply to this email and have > your reply appear on GitHub as well. If your project does not have > this feature enabled and wishes so, or if the feature is enabled but > not working, please contact infrastructure at > infrastruct...@apache.org or file a JIRA ticket with INFRA. > --- This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement, you may review at http://www.amdocs.com/email_disclaimer.asp
