> On Sept. 20, 2016, 12:32 a.m., Mark Bretl wrote: > > Looks good. I applied changes to a local workspace and found the duplicate > > jars removed from the pulse.war. > > > > Very minor: Do we want to add 'jar.enabled = false' to those projects > > (geode-pulse and geode-web-api) to make sure we will not create the jars in > > the future?
Thanks, I'll look into that. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52019/#review149582 ----------------------------------------------------------- On Sept. 19, 2016, 1:11 a.m., Anthony Baker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52019/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 1:11 a.m.) > > > Review request for geode, Dick Cavender, Jens Deppe, Jinmei Liao, and Mark > Bretl. > > > Repository: geode > > > Description > ------- > > Remove duplicate jar files from the lib directory of the > geode-web, geode-web-api, and geode-pulse war archives. Gradle > doesn't appear to be doing the correct thing, so force it using > a duplicates strategy. In addition, do not create geode-web-api > or geode-pulse jar files. These don't seem to be used anywhere. > > > Diffs > ----- > > geode-assembly/build.gradle 3ed864ba5dd2e9589d5cb8313fe59747b76a91b0 > geode-pulse/build.gradle e53a698700f0de62088b3ac50cb96d4841315124 > geode-web-api/build.gradle 388dbba7c9c0bc9134dbd5818c49edb9d0eae7a6 > geode-web/build.gradle 75844d39678c5acc617e70f9cfa77c1049ca9d69 > > Diff: https://reviews.apache.org/r/52019/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Baker > >
