> On Sept. 20, 2016, 2:17 p.m., Jens Deppe wrote:
> > geode-pulse.war contains geode-web.jar - I don't think it needs that.
> > 
> > Both geode-pulse.war and geode-web-api.war contain the relevant exploded 
> > classes. However, geode-web.war contains a geode-web.jar file with the 
> > actual classes. It would be nice to be consistent - whatever is easisest 
> > and clearer to set up in Gradle should be fine.

Unfortunately, geode-web.jar is generated in the geode-core project (for bad 
but necessary reasons that we should fix).  The simplest thing in gradle 
projects is to *not* bundle classes into a jar.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52019/#review149661
-----------------------------------------------------------


On Sept. 19, 2016, 1:11 a.m., Anthony Baker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52019/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 1:11 a.m.)
> 
> 
> Review request for geode, Dick Cavender, Jens Deppe, Jinmei Liao, and Mark 
> Bretl.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Remove duplicate jar files from the lib directory of the
> geode-web, geode-web-api, and geode-pulse war archives. Gradle
> doesn't appear to be doing the correct thing, so force it using
> a duplicates strategy.  In addition, do not create geode-web-api
> or geode-pulse jar files.  These don't seem to be used anywhere.
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle 3ed864ba5dd2e9589d5cb8313fe59747b76a91b0 
>   geode-pulse/build.gradle e53a698700f0de62088b3ac50cb96d4841315124 
>   geode-web-api/build.gradle 388dbba7c9c0bc9134dbd5818c49edb9d0eae7a6 
>   geode-web/build.gradle 75844d39678c5acc617e70f9cfa77c1049ca9d69 
> 
> Diff: https://reviews.apache.org/r/52019/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Baker
> 
>

Reply via email to