+1 - Checked signatures - Ran gfsh: ./gfsh version --full - Built from source - Verified Commit ID atches with source tar ball - Reviewed BUILDING.md
Under 'Build from Source on Windows' in BUILDING.md it states minimum Gradle is 2.12, when the gradle.properites file has 2.14.1. When run with 2.12, the build fails due to our Gradle version check. I am not sure how many people will try to build from source on Windows, but it is an issue. The workaround is to download the 2.14.1 version of Gradle.Its not a big deal, only a small issue out of the box with Windows. BUILDING.md needs to be updated. Also, a big +1 for the binary tar ball for 1.0 is 23MB smaller than M3. --Mark On Mon, Oct 17, 2016 at 3:54 PM, Karen Miller <kmil...@pivotal.io> wrote: > @Anil: > Without the fix that GEODE-1883 should bring, client caches only have 1 way > of setting > the security properties: do it via the callback. > > Once the fix is in, client caches should again have 2 ways of setting the > security > properties: 1. do it via the callback, or 2. place in a > security.properties file. > > The docs on the release/1.0.0-incubating branch (and therefore in the > release candidate) > list the 2 ways of setting the security properties. However, GEODE-1883 > has not been > fixed for the release candidate, so this documentation detail is wrong in > the release > candidate. > > The docs in the develop branch list only the 1 way. > > Does this explanation help? > > On Mon, Oct 17, 2016 at 2:54 PM, Anilkumar Gingade <aging...@pivotal.io> > wrote: > > > +1 for release... > > > > On Mon, Oct 17, 2016 at 2:54 PM, Anilkumar Gingade <aging...@pivotal.io> > > wrote: > > > > > Hi Karen, > > > > > > The fix still keeps the doc stating: > > > "a client will need to set its credential, composed of the two > properties > > > `security-username` and `security-password`." > > > > > > What i see is, additional doc about setting the auth properties using > > > callbacks.... > > > > > > Am i missing anything? > > > > > > -Anil. > > > > > > > > > > > > > > > On Mon, Oct 17, 2016 at 1:12 PM, Karen Miller <kmil...@pivotal.io> > > wrote: > > > > > >> +0 > > >> > > >> With GEODE-1883 being moved to a subsequent release, the just-donated > > docs > > >> are not-quite current with respect to how a client cache may set its > > >> credentials for > > >> authentication. I put in a fix for this on the develop branch: > > >> https://github.com/apache/incubator-geode/commit/f1df6fc5920 > > >> d0d1eebd210e816e61ad44074d39d > > >> > > >> If there were to be a third release candidate, a cherry pick of this > > >> commit > > >> will correct the > > >> 1.0.0-incubating documentation. > > >> > > >> > > >> > > >> On Mon, Oct 17, 2016 at 12:10 PM, Dan Smith <dsm...@pivotal.io> > wrote: > > >> > > >> > +1 > > >> > > > >> > Checked > > >> > * signatures > > >> > * maven repo with simple sample app > > >> > * command line test through gfsh > > >> > * built the source > > >> > > > >> > Checked it with this thing: > > >> > https://github.com/upthewaterspout/geode-release-check > > >> > > > >> > On Mon, Oct 17, 2016 at 11:55 AM, William Markito < > > wmark...@pivotal.io> > > >> > wrote: > > >> > > > >> > > +1 > > >> > > > > >> > > Checked SHA, signatures, build/run, sample app and command line > > >> testing > > >> > > through gfsh. > > >> > > > > >> > > On Mon, Oct 17, 2016 at 10:33 AM, Kirk Lund <kl...@pivotal.io> > > wrote: > > >> > > > > >> > > > +1 I think we should target GEODE-2004 and GEODE-1883 for a > point > > >> > release > > >> > > > after 1.0.0 > > >> > > > > > >> > > > > > >> > > > On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao <jil...@pivotal.io > > > > >> > wrote: > > >> > > > > > >> > > > > +0 > > >> > > > > > > >> > > > > This candidate does not include the fix for GEODE-2004 and > > >> > GEODE-1883. > > >> > > > It's > > >> > > > > not a must fix though. > > >> > > > > > > >> > > > > On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker < > > aba...@pivotal.io > > >> > > > >> > > > wrote: > > >> > > > > > > >> > > > > > +1 > > >> > > > > > > > >> > > > > > * Verified sha’s > > >> > > > > > * Verified signatures > > >> > > > > > * Verified tag signature > > >> > > > > > * Build and run from src distro > > >> > > > > > * Checked src distro for binaries > > >> > > > > > * Run some examples from mvn repo > > >> > > > > > * Reviewed LICENSE and NOTICE > > >> > > > > > > > >> > > > > > Anthony > > >> > > > > > > > >> > > > > > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar < > > >> > > sbawas...@pivotal.io> > > >> > > > > > wrote: > > >> > > > > > > > > >> > > > > > > All, > > >> > > > > > > > > >> > > > > > > This is the second release candidate for Apache Geode, > > version > > >> > > > > > > 1.0.0-incubating. I discarded the first release candidate > > >> since > > >> > my > > >> > > > pgp > > >> > > > > > > key was missing from the KEYS file. > > >> > > > > > > Thanks to all the community members to drive towards this > > >> > > milestone! > > >> > > > > > > > > >> > > > > > > It fixes the following issues: > > >> > > > > > > > > >> > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa > ? > > >> > > > > > projectId=12318420&version=12332343 > > >> > > > > > > > > >> > > > > > > *** Please download, test and vote by Wednesday, October > 19, > > >> 0800 > > >> > > hrs > > >> > > > > > > US Pacific. > > >> > > > > > > > > >> > > > > > > Note that we are voting upon the source (tag): > > >> > > > > > > rel/1.0.0-incubating.RC2 > > >> > > > > > > <https://git-wip-us.apache.org/repos/asf?p=incubator- > > >> > > > > > geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.RC2> > > >> > > > > > > > > >> > > > > > > Commit ID: 280a407c59a89401d5d87d6e6aeda1c975870753 > > >> > > > > > > <https://git-wip-us.apache.org/repos/asf?p=incubator- > > >> > > > > > geode.git;a=commit;h=280a407c59a89401d5d87d6e6aeda1 > > c975870753> > > >> > > > > > > > > >> > > > > > > Source and binary files: > > >> > > > > > > https://dist.apache.org/repos/ > > dist/dev/incubator/geode/1.0. > > >> > > > > > 0-incubating.RC2/ > > >> > > > > > > > > >> > > > > > > The documentation on how to install and use Apache Geode > are > > >> > hosted > > >> > > > > > > on pivotal.io: > > >> > > > > > > http://geode.docs.pivotal.io > > >> > > > > > > > > >> > > > > > > Maven staging repo: > > >> > > > > > > https://repository.apache.org/content/repositories/ > > >> > > > > > orgapachegeode-1014/ > > >> > > > > > > > > >> > > > > > > Geode's KEYS file containing PGP keys we use to sign the > > >> release: > > >> > > > > > > https://github.com/apache/incubator-geode/blob/release/ > > >> > > > > > 1.0.0-incubating/KEYS > > >> > > > > > > > > >> > > > > > > Release Signed with Key: pub 4096R/18F902DB 2016-04-07 > > >> > > > > > > Fingerprint: E1B1 ABE3 4753 E7BA 8097 4285 8F8F 2BCC 18F9 > > >> 02DB > > >> > > > > > > > > >> > > > > > > Thanks, > > >> > > > > > > > > >> > > > > > > Swapnil. > > >> > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > -- > > >> > > > > Cheers > > >> > > > > > > >> > > > > Jinmei > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > -- > > >> > > > > >> > > ~/William > > >> > > > > >> > > > >> > > > > > > > > >
